greg/cpython
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

gh-131798: JIT - Use sym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SET (GH-132564)

Browse Source 
Signed-off-by: Manjusaka <me@manjusaka.me>
This commit is contained in:
Nadeshiko Manju
2025-04-27 20:30:28 +08:00
committed by GitHub
parent 8b4fd24ca5
commit 614d79231d
3 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Misc/NEWS.d/next/Core_and_Builtins/2025-04-26-18-43-31.gh-issue-131798.FsIypo.rst Normal file
View File

@@ -0,0 +1,2 @@
Use ``sym_new_type`` instead of ``sym_new_not_null`` for _BUILD_STRING,
_BUILD_SET

8
Python/optimizer_bytecodes.c
View File

@@ -977,6 +977,14 @@ dummy_func(void) {
map = sym_new_type(ctx, &PyDict_Type); map = sym_new_type(ctx, &PyDict_Type);
} }
op(_BUILD_STRING, (values[oparg] -- str)) {
str = sym_new_type(ctx, &PyUnicode_Type);
}
op(_BUILD_SET, (values[oparg] -- set)) {
set = sym_new_type(ctx, &PySet_Type);
}
op(_UNPACK_SEQUENCE_TWO_TUPLE, (seq -- val1, val0)) { op(_UNPACK_SEQUENCE_TWO_TUPLE, (seq -- val1, val0)) {
val0 = sym_tuple_getitem(ctx, seq, 0); val0 = sym_tuple_getitem(ctx, seq, 0);
val1 = sym_tuple_getitem(ctx, seq, 1); val1 = sym_tuple_getitem(ctx, seq, 1);

4
Python/optimizer_cases.c.h generated
View File

@@ -1032,7 +1032,7 @@
case _BUILD_STRING: { case _BUILD_STRING: {
JitOptSymbol *str; JitOptSymbol *str;
str = sym_new_not_null(ctx); str = sym_new_type(ctx, &PyUnicode_Type);
stack_pointer[-oparg] = str; stack_pointer[-oparg] = str;
stack_pointer += 1 - oparg; stack_pointer += 1 - oparg;
assert(WITHIN_STACK_BOUNDS()); assert(WITHIN_STACK_BOUNDS());
@@ -1073,7 +1073,7 @@
case _BUILD_SET: { case _BUILD_SET: {
JitOptSymbol *set; JitOptSymbol *set;
set = sym_new_not_null(ctx); set = sym_new_type(ctx, &PySet_Type);
stack_pointer[-oparg] = set; stack_pointer[-oparg] = set;
stack_pointer += 1 - oparg; stack_pointer += 1 - oparg;
assert(WITHIN_STACK_BOUNDS()); assert(WITHIN_STACK_BOUNDS());