greg/cpython
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

gh-90110: Update the C-analyzer Tool (gh-99307)

Browse Source
This commit is contained in:
Eric Snow
2022-11-10 09:03:57 -07:00
committed by GitHub
parent 6dedf42527
commit 73679b13ca
4 changed files with 14 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Modules/zlibmodule.c
View File

@@ -1718,7 +1718,7 @@ ZlibDecompressor__new__(PyTypeObject *cls,
PyObject *kwargs) PyObject *kwargs)
{ {
static char *keywords[] = {"wbits", "zdict", NULL}; static char *keywords[] = {"wbits", "zdict", NULL};
static char *format = "|iO:_ZlibDecompressor"; static const char * const format = "|iO:_ZlibDecompressor";
int wbits = MAX_WBITS; int wbits = MAX_WBITS;
PyObject *zdict = NULL; PyObject *zdict = NULL;
zlibstate *state = PyType_GetModuleState(cls); zlibstate *state = PyType_GetModuleState(cls);

6
Tools/c-analyzer/cpython/_parser.py
View File

@@ -82,6 +82,10 @@ Objects/unicodetype_db.h
# generated # generated
Python/deepfreeze/*.c Python/deepfreeze/*.c
Python/frozen_modules/*.h Python/frozen_modules/*.h
Python/generated_cases.c.h
# not actually source
Python/bytecodes.c
# @end=conf@ # @end=conf@
''') ''')
@@ -285,6 +289,7 @@ Objects/stringlib/codecs.h STRINGLIB_IS_UNICODE 1
SAME = { SAME = {
_abs('Include/*.h'): [_abs('Include/cpython/')], _abs('Include/*.h'): [_abs('Include/cpython/')],
_abs('Python/ceval.c'): ['Python/generated_cases.c.h'],
} }
MAX_SIZES = { MAX_SIZES = {
@@ -311,6 +316,7 @@ MAX_SIZES = {
_abs('Python/frozen_modules/*.h'): (20_000, 500), _abs('Python/frozen_modules/*.h'): (20_000, 500),
_abs('Python/opcode_targets.h'): (10_000, 500), _abs('Python/opcode_targets.h'): (10_000, 500),
_abs('Python/stdlib_module_names.h'): (5_000, 500), _abs('Python/stdlib_module_names.h'): (5_000, 500),
_abs('Python/importlib.h'): (200_000, 5000),
# These large files are currently ignored (see above). # These large files are currently ignored (see above).
_abs('Modules/_ssl_data.h'): (80_000, 10_000), _abs('Modules/_ssl_data.h'): (80_000, 10_000),

91
Tools/c-analyzer/cpython/globals-to-fix.tsv
View File

@@ -304,20 +304,14 @@ Objects/sliceobject.c - _Py_EllipsisObject -
# manually cached PyUnicodeObject # manually cached PyUnicodeObject
Python/ast_unparse.c - _str_replace_inf - Python/ast_unparse.c - _str_replace_inf -
# holds statically-initialized strings
Objects/typeobject.c - slotdefs -
# other # other
Objects/typeobject.c object___reduce_ex___impl objreduce - Objects/typeobject.c object___reduce_ex___impl objreduce -
Objects/unicodeobject.c - _string_module -
Objects/unicodeobject.c - interned -
#----------------------- #-----------------------
# other # other
# initialized once # initialized once
Python/context.c - _token_missing - Python/context.c - _token_missing -
Python/fileutils.c - _Py_open_cloexec_works -
Python/hamt.c - _empty_bitmap_node - Python/hamt.c - _empty_bitmap_node -
Python/hamt.c - _empty_hamt - Python/hamt.c - _empty_hamt -
@@ -384,6 +378,7 @@ Python/perf_trampoline.c - perf_map_file -
Objects/unicodeobject.c - ucnhash_capi - Objects/unicodeobject.c - ucnhash_capi -
Parser/action_helpers.c _PyPegen_dummy_name cache - Parser/action_helpers.c _PyPegen_dummy_name cache -
Python/dtoa.c - p5s - Python/dtoa.c - p5s -
Python/fileutils.c - _Py_open_cloexec_works -
Python/fileutils.c - force_ascii - Python/fileutils.c - force_ascii -
Python/fileutils.c set_inheritable ioctl_works - Python/fileutils.c set_inheritable ioctl_works -
Python/import.c - import_lock - Python/import.c - import_lock -
@@ -511,6 +506,7 @@ Modules/_testcapi/vectorcall.c - MethodDescriptorNopGet_Type -
Modules/_testcapi/vectorcall.c - MethodDescriptor2_Type - Modules/_testcapi/vectorcall.c - MethodDescriptor2_Type -
Modules/itertoolsmodule.c - _grouper_type - Modules/itertoolsmodule.c - _grouper_type -
Modules/itertoolsmodule.c - accumulate_type - Modules/itertoolsmodule.c - accumulate_type -
Modules/itertoolsmodule.c - batched_type -
Modules/itertoolsmodule.c - chain_type - Modules/itertoolsmodule.c - chain_type -
Modules/itertoolsmodule.c - combinations_type - Modules/itertoolsmodule.c - combinations_type -
Modules/itertoolsmodule.c - compress_type - Modules/itertoolsmodule.c - compress_type -
@@ -701,89 +697,6 @@ Modules/xxmodule.c - ErrorObject -
#----------------------- #-----------------------
# cached - initialized once # cached - initialized once
# _Py_IDENTIFIER (global)
Modules/_asynciomodule.c - PyId___asyncio_running_event_loop__ -
Modules/_asynciomodule.c - PyId__asyncio_future_blocking -
Modules/_asynciomodule.c - PyId_add_done_callback -
Modules/_asynciomodule.c - PyId_call_soon -
Modules/_asynciomodule.c - PyId_cancel -
Modules/_asynciomodule.c - PyId_get_event_loop -
Modules/_asynciomodule.c - PyId_throw -
Modules/_datetimemodule.c - PyId_as_integer_ratio -
Modules/_datetimemodule.c - PyId_fromutc -
Modules/_datetimemodule.c - PyId_isoformat -
Modules/_datetimemodule.c - PyId_strftime -
# _Py_IDENTIFIER (local)
Modules/_asynciomodule.c FutureObj_finalize PyId_call_exception_handler -
Modules/_asynciomodule.c FutureObj_finalize PyId_exception -
Modules/_asynciomodule.c FutureObj_finalize PyId_future -
Modules/_asynciomodule.c FutureObj_finalize PyId_message -
Modules/_asynciomodule.c FutureObj_finalize PyId_source_traceback -
Modules/_asynciomodule.c FutureObj_get_state PyId_CANCELLED -
Modules/_asynciomodule.c FutureObj_get_state PyId_FINISHED -
Modules/_asynciomodule.c FutureObj_get_state PyId_PENDING -
Modules/_asynciomodule.c TaskObj_finalize PyId_call_exception_handler -
Modules/_asynciomodule.c TaskObj_finalize PyId_message -
Modules/_asynciomodule.c TaskObj_finalize PyId_source_traceback -
Modules/_asynciomodule.c TaskObj_finalize PyId_task -
Modules/_asynciomodule.c future_init PyId_get_debug -
Modules/_asynciomodule.c get_future_loop PyId__loop -
Modules/_asynciomodule.c get_future_loop PyId_get_loop -
Modules/_asynciomodule.c register_task PyId_add -
Modules/_asynciomodule.c unregister_task PyId_discard -
Modules/_ctypes/_ctypes.c CDataType_from_param PyId__as_parameter_ -
Modules/_ctypes/_ctypes.c PyCArrayType_new PyId__length_ -
Modules/_ctypes/_ctypes.c PyCArrayType_new PyId__type_ -
Modules/_ctypes/_ctypes.c PyCFuncPtr_set_restype PyId__check_retval_ -
Modules/_ctypes/_ctypes.c PyCPointerType_new PyId__type_ -
Modules/_ctypes/_ctypes.c PyCPointerType_set_type PyId__type_ -
Modules/_ctypes/_ctypes.c PyCSimpleType_from_param PyId__as_parameter_ -
Modules/_ctypes/_ctypes.c PyCSimpleType_new PyId__type_ -
Modules/_ctypes/_ctypes.c StructUnionType_new PyId__abstract_ -
Modules/_ctypes/_ctypes.c StructUnionType_new PyId__fields_ -
Modules/_ctypes/_ctypes.c _build_result PyId___ctypes_from_outparam__ -
Modules/_ctypes/_ctypes.c _init_pos_args PyId__fields_ -
Modules/_ctypes/_ctypes.c c_char_p_from_param PyId__as_parameter_ -
Modules/_ctypes/_ctypes.c c_void_p_from_param PyId__as_parameter_ -
Modules/_ctypes/_ctypes.c c_wchar_p_from_param PyId__as_parameter_ -
Modules/_ctypes/_ctypes.c converters_from_argtypes PyId_from_param -
Modules/_ctypes/_ctypes.c make_funcptrtype_dict PyId__argtypes_ -
Modules/_ctypes/_ctypes.c make_funcptrtype_dict PyId__check_retval_ -
Modules/_ctypes/_ctypes.c make_funcptrtype_dict PyId__flags_ -
Modules/_ctypes/_ctypes.c make_funcptrtype_dict PyId__restype_ -
Modules/_ctypes/callproc.c ConvParam PyId__as_parameter_ -
Modules/_ctypes/callproc.c unpickle PyId___new__ -
Modules/_ctypes/callproc.c unpickle PyId___setstate__ -
Modules/_ctypes/stgdict.c MakeAnonFields PyId__anonymous_ -
Modules/_ctypes/stgdict.c PyCStructUnionType_update_stgdict PyId__pack_ -
Modules/_ctypes/stgdict.c PyCStructUnionType_update_stgdict PyId__swappedbytes_ -
Modules/_ctypes/stgdict.c PyCStructUnionType_update_stgdict PyId__use_broken_old_ctypes_structure_semantics_ -
Modules/_cursesmodule.c _curses_getwin PyId_read -
Modules/_cursesmodule.c _curses_window_putwin PyId_write -
Modules/_cursesmodule.c update_lines_cols PyId_COLS -
Modules/_cursesmodule.c update_lines_cols PyId_LINES -
Modules/_datetimemodule.c call_tzname PyId_tzname -
Modules/_datetimemodule.c date_strftime PyId_timetuple -
Modules/_datetimemodule.c date_today PyId_fromtimestamp -
Modules/_datetimemodule.c datetime_strptime PyId__strptime_datetime -
Modules/_datetimemodule.c make_Zreplacement PyId_replace -
Modules/_datetimemodule.c tzinfo_reduce PyId___getinitargs__ -
Modules/_elementtree.c _elementtree_Element_find_impl PyId_find -
Modules/_elementtree.c _elementtree_Element_findall_impl PyId_findall -
Modules/_elementtree.c _elementtree_Element_findtext_impl PyId_findtext -
Modules/_elementtree.c _elementtree_Element_iterfind_impl PyId_iterfind -
Modules/_elementtree.c expat_start_doctype_handler PyId_doctype -
Modules/_elementtree.c treebuilder_add_subelement PyId_append -
Modules/_elementtree.c treebuilder_flush_data PyId_tail -
Modules/_elementtree.c treebuilder_flush_data PyId_text -
Modules/_json.c _encoded_const PyId_false -
Modules/_json.c _encoded_const PyId_null -
Modules/_json.c _encoded_const PyId_true -
Modules/_json.c raise_errmsg PyId_JSONDecodeError -
Modules/_json.c raise_errmsg PyId_decoder -
Modules/ossaudiodev.c oss_exit PyId_close -
# manually cached PyUnicodeOjbect # manually cached PyUnicodeOjbect
Modules/_asynciomodule.c - context_kwname - Modules/_asynciomodule.c - context_kwname -
Modules/_ctypes/callproc.c _ctypes_get_errobj error_object_name - Modules/_ctypes/callproc.c _ctypes_get_errobj error_object_name -
1 filename funcname name reason
304 Objects/typeobject.c # initialized/set once
305 Python/import.c # pre-allocated buffer
306 ################################## Modules/getbuildinfo.c Py_GetBuildInfo buildinfo -
# global non-objects to fix in core code
#-----------------------
# initialized/set once
307 # pre-allocated buffer # during init
308 Modules/getbuildinfo.c Objects/unicodeobject.c Py_GetBuildInfo - buildinfo bloom_linebreak -
# during init
Objects/unicodeobject.c - bloom_linebreak -
309 Python/bootstrap_hash.c - _Py_HashSecret_Initialized -
310 Python/bootstrap_hash.c py_getrandom getrandom_works -
311 Python/initconfig.c - _Py_global_config_int_max_str_digits -
312 Python/initconfig.c - Py_DebugFlag -
313 Python/initconfig.c - Py_UTF8Mode -
314 Python/initconfig.c - Py_DebugFlag -
Python/initconfig.c - Py_VerboseFlag -
315 Python/initconfig.c - Py_QuietFlag Py_VerboseFlag -
316 Python/initconfig.c - Py_InteractiveFlag Py_QuietFlag -
317 Python/initconfig.c - Py_InspectFlag Py_InteractiveFlag -
378 Python/getopt.c # handling C argv
379 Python/getopt.c - _PyOS_optind _PyOS_optarg -
380 Python/getopt.c - opt_ptr _PyOS_opterr -
381 Python/getopt.c - _PyOS_optind -
382 Python/pathconfig.c Python/getopt.c - _Py_path_config opt_ptr -
383 #----------------------- Python/pathconfig.c - _Py_path_config -
384 # state #-----------------------
506 Modules/signalmodule.c Modules/faulthandler.c - Handlers stack -
507 ################################## Modules/faulthandler.c - old_stack -
508 # global non-objects to fix in builtin modules Modules/signalmodule.c - Handlers -
509 ##################################
510 #----------------------- # global non-objects to fix in builtin modules
511 # initialized once #-----------------------
512 Modules/_io/bufferedio.c # initialized once
697 Modules/_cursesmodule.c Modules/syslogmodule.c _curses_window_putwin - PyId_write S_ident_o -
698 Modules/_cursesmodule.c ##################################
699 Modules/_cursesmodule.c # global non-objects to fix in extension modules
Modules/_datetimemodule.c call_tzname PyId_tzname -
Modules/_datetimemodule.c date_strftime PyId_timetuple -
Modules/_datetimemodule.c date_today PyId_fromtimestamp -
Modules/_datetimemodule.c datetime_strptime PyId__strptime_datetime -
Modules/_datetimemodule.c make_Zreplacement PyId_replace -
Modules/_datetimemodule.c tzinfo_reduce PyId___getinitargs__ -
Modules/_elementtree.c _elementtree_Element_find_impl PyId_find -
Modules/_elementtree.c _elementtree_Element_findall_impl PyId_findall -
Modules/_elementtree.c _elementtree_Element_findtext_impl PyId_findtext -
Modules/_elementtree.c _elementtree_Element_iterfind_impl PyId_iterfind -
Modules/_elementtree.c expat_start_doctype_handler PyId_doctype -
Modules/_elementtree.c treebuilder_add_subelement PyId_append -
Modules/_elementtree.c treebuilder_flush_data PyId_tail -
Modules/_elementtree.c treebuilder_flush_data PyId_text -
Modules/_json.c _encoded_const PyId_false -
Modules/_json.c _encoded_const PyId_null -
Modules/_json.c _encoded_const PyId_true -
Modules/_json.c raise_errmsg PyId_JSONDecodeError -
Modules/_json.c raise_errmsg PyId_decoder -
Modules/ossaudiodev.c oss_exit PyId_close -
# manually cached PyUnicodeOjbect
Modules/_asynciomodule.c - context_kwname -
Modules/_ctypes/callproc.c _ctypes_get_errobj error_object_name -
Modules/_ctypes/_ctypes.c CreateSwappedType suffix -
# other - during module init
Modules/_asynciomodule.c - asyncio_mod -
Modules/_asynciomodule.c - traceback_extract_stack -
Modules/_asynciomodule.c - asyncio_future_repr_func -
Modules/_asynciomodule.c - asyncio_get_event_loop_policy -
Modules/_asynciomodule.c - asyncio_iscoroutine_func -
Modules/_asynciomodule.c - asyncio_task_get_stack_func -
Modules/_asynciomodule.c - asyncio_task_print_stack_func -
Modules/_asynciomodule.c - asyncio_task_repr_func -
Modules/_asynciomodule.c - asyncio_InvalidStateError -
Modules/_asynciomodule.c - asyncio_CancelledError -
Modules/_zoneinfo.c - io_open -
Modules/_zoneinfo.c - _tzpath_find_tzfile -
Modules/_zoneinfo.c - _common_mod -
#-----------------------
# other
# initialized once
Modules/_ctypes/_ctypes.c - _unpickle -
Modules/_ctypes/_ctypes.c PyCArrayType_from_ctype cache -
Modules/_cursesmodule.c - ModDict -
Modules/_datetimemodule.c datetime_strptime module -
Modules/_datetimemodule.c - PyDateTime_TimeZone_UTC -
Modules/_datetimemodule.c - PyDateTime_Epoch -
Modules/_datetimemodule.c - us_per_ms -
Modules/_datetimemodule.c - us_per_second -
Modules/_datetimemodule.c - us_per_minute -
Modules/_datetimemodule.c - us_per_hour -
Modules/_datetimemodule.c - us_per_day -
Modules/_datetimemodule.c - us_per_week -
Modules/_datetimemodule.c - seconds_per_day -
Modules/_decimal/_decimal.c - basic_context_template -
Modules/_decimal/_decimal.c - current_context_var -
Modules/_decimal/_decimal.c - default_context_template -
Modules/_decimal/_decimal.c - extended_context_template -
Modules/_decimal/_decimal.c - round_map -
Modules/_decimal/_decimal.c - Rational -
Modules/_decimal/_decimal.c - SignalTuple -
Modules/arraymodule.c array_array___reduce_ex___impl array_reconstructor -
# state
Modules/_asynciomodule.c - cached_running_holder -
Modules/_asynciomodule.c - fi_freelist -
Modules/_asynciomodule.c - fi_freelist_len -
Modules/_asynciomodule.c - all_tasks -
Modules/_asynciomodule.c - current_tasks -
Modules/_asynciomodule.c - iscoroutine_typecache -
Modules/_ctypes/_ctypes.c - _ctypes_ptrtype_cache -
Modules/_testinternalcapi.c - record_list -
Modules/_tkinter.c - tcl_lock -
Modules/_tkinter.c - excInCmd -
Modules/_tkinter.c - valInCmd -
Modules/_tkinter.c - trbInCmd -
Modules/_zoneinfo.c - TIMEDELTA_CACHE -
Modules/_zoneinfo.c - ZONEINFO_WEAK_CACHE -
Modules/syslogmodule.c - S_ident_o -
##################################
# global non-objects to fix in extension modules
#-----------------------
# initialized once
# pre-allocated buffer
700 Modules/nismodule.c #-----------------------
701 Modules/pyexpat.c # initialized once
702 # other # pre-allocated buffer

5
Tools/c-analyzer/cpython/ignored.tsv
View File

@@ -261,6 +261,10 @@ Modules/_testcapimodule.c test_capsule buffer -
Modules/_testcapimodule.c test_empty_argparse kwlist - Modules/_testcapimodule.c test_empty_argparse kwlist -
Modules/_testcapimodule.c test_structmembers_new keywords - Modules/_testcapimodule.c test_structmembers_new keywords -
Modules/_testcapimodule.c getargs_s_hash_int keywords - Modules/_testcapimodule.c getargs_s_hash_int keywords -
Modules/_testcapimodule.c - g_dict_watch_events -
Modules/_testcapimodule.c - g_dict_watchers_installed -
Modules/_testcapimodule.c - g_type_modified_events -
Modules/_testcapimodule.c - g_type_watchers_installed -
Modules/_testimportmultiple.c - _barmodule - Modules/_testimportmultiple.c - _barmodule -
Modules/_testimportmultiple.c - _foomodule - Modules/_testimportmultiple.c - _foomodule -
Modules/_testimportmultiple.c - _testimportmultiple - Modules/_testimportmultiple.c - _testimportmultiple -
@@ -467,6 +471,7 @@ Objects/obmalloc.c - _PyObject -
Objects/obmalloc.c - usedpools - Objects/obmalloc.c - usedpools -
Python/perf_trampoline.c - _Py_perfmap_callbacks - Python/perf_trampoline.c - _Py_perfmap_callbacks -
Objects/typeobject.c - name_op - Objects/typeobject.c - name_op -
Objects/typeobject.c - slotdefs -
Objects/unicodeobject.c - stripfuncnames - Objects/unicodeobject.c - stripfuncnames -
Objects/unicodeobject.c - utf7_category - Objects/unicodeobject.c - utf7_category -
Objects/unicodeobject.c unicode_decode_call_errorhandler_wchar argparse - Objects/unicodeobject.c unicode_decode_call_errorhandler_wchar argparse -
1 filename funcname name reason
261 Modules/_testmultiphase.c Modules/_testinternalcapi.c - StateAccessType_Type_slots _testcapimodule -
262 Modules/_testmultiphase.c - StateAccessType_methods Example_Type_slots -
263 Modules/_testmultiphase.c - StateAccessType_spec Example_Type_spec -
264 Modules/_testmultiphase.c - Example_methods -
265 Modules/_testmultiphase.c - StateAccessType_Type_slots -
266 Modules/_testmultiphase.c - StateAccessType_methods -
267 Modules/_testmultiphase.c - StateAccessType_spec -
268 Modules/_testmultiphase.c - Str_Type_slots -
269 Modules/_testmultiphase.c - Str_Type_spec -
270 Modules/_testmultiphase.c - def_bad_large -
471 Python/compile.c Python/codecs.c - _PyCodecRegistry_Init NO_LABEL methods -
472 Python/compile.c - NO_LOCATION NO_LABEL -
473 Python/dynload_shlib.c Python/compile.c - _PyImport_DynLoadFiletab NO_LOCATION -
474 Python/dynload_shlib.c - _PyImport_DynLoadFiletab -
475 Python/dynload_stub.c - _PyImport_DynLoadFiletab -
476 Python/frozen.c - aliases -
477 Python/frozen.c - bootstrap_modules -