From 3a606608fbb2593596a0c6c04a6114cf5fdbea92 Mon Sep 17 00:00:00 2001 From: Erik Arvstedt Date: Thu, 26 Mar 2020 10:14:03 +0100 Subject: [PATCH] remove custom no-upnp bitcoind builds Disabling upnp via compilation brings no substantial security benefits. There's no way to inadvertently enable upnp, it must be set explicitly via bitcoind.extraConfig. But it's a huge hassle for new users who have to recompile bitcoind before being able to use nix-bitcoin. Also, elementsd is currently built with upnp support by default. --- pkgs/pinned.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/pinned.nix b/pkgs/pinned.nix index 5bc69ac..a03a46d 100644 --- a/pkgs/pinned.nix +++ b/pkgs/pinned.nix @@ -4,9 +4,9 @@ let nixBitcoinPkgsUnstable = import ./. { pkgs = unstable; }; in { - bitcoin = unstable.bitcoin.override { miniupnpc = null; }; - bitcoind = unstable.bitcoind.override { miniupnpc = null; }; inherit (unstable) + bitcoin + bitcoind clightning lnd; inherit (nixBitcoinPkgsUnstable) electrs;