From cc3d43f4e95b2431eea271f8803d8152f2afc742 Mon Sep 17 00:00:00 2001
From: Erik Arvstedt <erik.arvstedt@gmail.com>
Date: Thu, 28 Oct 2021 22:23:24 +0200
Subject: [PATCH] bitcoind: set onionPort in bitcoind module

This removes the module-level dependency from onion-services to
bitcoind.
Due to the `or false` fallback, there's no dependency added in
the reverse direction.

In particular, this allows us to not add a dependency on liquidd in
the following commit.
---
 modules/bitcoind.nix       | 4 +++-
 modules/onion-services.nix | 4 ----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/modules/bitcoind.nix b/modules/bitcoind.nix
index 4997024..8a75f2f 100644
--- a/modules/bitcoind.nix
+++ b/modules/bitcoind.nix
@@ -17,7 +17,9 @@ let
       };
       onionPort = mkOption {
         type = types.nullOr types.port;
-        default = null;
+        # When the bitcoind onion service is enabled, add an onion-tagged socket
+        # to distinguish local connections from Tor connections
+        default = if (config.nix-bitcoin.onionServices.bitcoind.enable or false) then 8334 else null;
         description = ''
           Port to listen for Tor peer connections.
           If set, inbound connections to this port are tagged as onion peers.
diff --git a/modules/onion-services.nix b/modules/onion-services.nix
index 8fa3549..655f579 100644
--- a/modules/onion-services.nix
+++ b/modules/onion-services.nix
@@ -118,10 +118,6 @@ in {
           externalPort = 80;
         };
       };
-
-      # When the bitcoind onion service is enabled, add an onion-tagged socket
-      # to distinguish local connections from Tor connections
-      services.bitcoind.onionPort = mkIf (cfg.bitcoind.enable or false) 8334;
     }
   ];
 }