greg/schala
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update more notes

Browse Source
This commit is contained in:
greg 2019-09-10 03:33:28 -07:00
parent 72944ded1b
commit 1ecf1e506c
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
TODO.md
View File

@ -1,9 +1,10 @@
# TODO items # TODO items
## General code cleanup ## General code cleanup
- standardize on an error type that isn't String
-give scope reduction reference to symbol_table
-turn ast reduction into methods-on-struct-returning-result format -turn ast reduction into methods-on-struct-returning-result format
-implement and test open/use statements
- standardize on an error type that isn't String
-implement a visitor pattern for the use of scope_resolver
## Reduction ## Reduction
- make a good type for actual language builtins to avoid string comparisons - make a good type for actual language builtins to avoid string comparisons

1
schala-lang/language/src/reduced_ast.rs
View File

@ -160,6 +160,7 @@ impl Meta<Expression> {
Some(ref fqsn) => fqsn, Some(ref fqsn) => fqsn,
None => return Expr::ReductionError(format!("FQSN lookup for Value {:?} failed", qualified_name)), None => return Expr::ReductionError(format!("FQSN lookup for Value {:?} failed", qualified_name)),
}; };
//TODO this probably needs to change
let FullyQualifiedSymbolName(ref v) = sym_name; let FullyQualifiedSymbolName(ref v) = sym_name;
let name = v.last().unwrap().name.clone(); let name = v.last().unwrap().name.clone();
match symbol_table.lookup_by_fqsn(&sym_name) { match symbol_table.lookup_by_fqsn(&sym_name) {