gh-92936: allow double quote in cookie values (#113663)

* allow double quote in cookie values
* Update Lib/test/test_http_cookies.py

Co-authored-by: Senthil Kumaran <senthil@python.org>
This commit is contained in:
Nick Burns
2025-08-08 12:07:15 -07:00
committed by GitHub
parent 34d7351ac7
commit d7dbde8958
3 changed files with 26 additions and 1 deletions

View File

@@ -426,7 +426,7 @@ _CookiePattern = re.compile(r"""
( # Optional group: there may not be a value.
\s*=\s* # Equal Sign
(?P<val> # Start of group 'val'
"(?:[^\\"]|\\.)*" # Any double-quoted string
"(?:\\"|.)*?" # Any double-quoted string
| # or
# Special case for "expires" attr
(\w{3,6}day|\w{3}),\s # Day of the week or abbreviated day

View File

@@ -48,6 +48,29 @@ class CookieTests(unittest.TestCase):
'Set-Cookie: d=r',
'Set-Cookie: f=h'
))
},
# gh-92936: allow double quote in cookie values
{
'data': 'cookie="{"key": "value"}"',
'dict': {'cookie': '{"key": "value"}'},
'repr': "<SimpleCookie: cookie='{\"key\": \"value\"}'>",
'output': 'Set-Cookie: cookie="{"key": "value"}"',
},
{
'data': 'key="some value; surrounded by quotes"',
'dict': {'key': 'some value; surrounded by quotes'},
'repr': "<SimpleCookie: key='some value; surrounded by quotes'>",
'output': 'Set-Cookie: key="some value; surrounded by quotes"',
},
{
'data': 'session="user123"; preferences="{"theme": "dark"}"',
'dict': {'session': 'user123', 'preferences': '{"theme": "dark"}'},
'repr': "<SimpleCookie: preferences='{\"theme\": \"dark\"}' session='user123'>",
'output': '\n'.join((
'Set-Cookie: preferences="{"theme": "dark"}"',
'Set-Cookie: session="user123"',
))
}
]

View File

@@ -0,0 +1,2 @@
Update regex used by ``http.cookies.SimpleCookie`` to handle values containing
double quotes.